Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Log validation did not catch recent errors with vcell image #59

Closed
bilalshaikh42 opened this issue Feb 5, 2022 · 3 comments
Closed
Assignees
Labels
bug Something isn't working

Comments

@bilalshaikh42
Copy link
Contributor

What is the bug?

Recent versions of vcell have not been producing logs as expected on Biosimulations.
See biosimulations/biosimulations#4134 and biosimulations/biosimulations#4035
However, these versions (7.4.0.34 and 7.4.0.32) passed validation and were marked as valid in the database.

When does the bug occur?

No response

How should BioSimulators have behaved?

Ideally, these errors would be caught by the validation. It is possible that there is some sort of environment difference on the HPC that is causing different behavior between the HPC and the validation suite.

Screenshots

No response

Which types of devices does the bug occur in?

No response

Which operating systems does the bug occur in?

No response

Which browsers does the bug occur in?

No response

@bilalshaikh42 bilalshaikh42 added the bug Something isn't working label Feb 5, 2022
@jonrkarr
Copy link
Member

jonrkarr commented Feb 5, 2022

The simulator validation is using the API to validate logs. The simulator testing does not test every algorithm. If vcell doesn't generate logs consistently, this could be missed by the simulator test suite.

@jonrkarr
Copy link
Member

The VCell issue isn't specifically related to logs. Its related to output being directed to a subdirectory.

@jonrkarr jonrkarr transferred this issue from biosimulators/Biosimulators Feb 11, 2022
@jonrkarr jonrkarr self-assigned this Feb 11, 2022
@jonrkarr
Copy link
Member

Done. Released with 0.1.84.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

No branches or pull requests

2 participants