Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Debug posting of results to GitHub issues #36

Closed
jonrkarr opened this issue Mar 21, 2021 · 1 comment
Closed

Debug posting of results to GitHub issues #36

jonrkarr opened this issue Mar 21, 2021 · 1 comment
Assignees
@jonrkarr

Comments

@jonrkarr
Copy link
Member

Example:
https://github.com/biosimulators/Biosimulators/issues/144
@jonrkarr jonrkarr transferred this issue from biosimulators/Biosimulators_utils Mar 25, 2021
@jonrkarr jonrkarr self-assigned this Mar 25, 2021
@jonrkarr
Copy link
Member Author

Done

  • Results are now also summarized to console in case of problems posting them to comments on issues
  • I added information to the comments posted to issues that
    • the test log is available in the console output of the associated GitHub action
    • The test results are also stored as a JSON-formatted artifact of the associated GitHub action
  • I think the issue was that the GitHub API limits comments on issues to 64k characters. To get around this
    • I split the summary and information about passes, failures, and skips into 4 comments into of 1 comment
    • The code will now truncate messages at the 64k limit and append ... to the end
    • If the truncated message is still reject, the code tries to catch this failure and provide a more human-understandable error message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jonrkarr jonrkarr

Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jonrkarr