Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the details of simulator specification errors #20

Closed
jonrkarr opened this issue Jan 29, 2021 · 1 comment
Closed

Improve the details of simulator specification errors #20

jonrkarr opened this issue Jan 29, 2021 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@jonrkarr
Copy link
Member

The validator returns this

{
  "error": [
    {
      "status": "400",
      "title": "ValidatorError",
      "detail": "Algorithms must be annotated with unique KiSAO terms",
      "source": {
        "pointer": "/algorithms"
      }
    }
  ]
}

However, the test suite displays this

- Simulator specifications from https://raw.githubusercontent.com/biosimulators/Biosimulators_VCell/00d08a031a0788435b44989e73ae3f43f33e4cb0/biosimulators.json are not valid. Specifications must be adhere to the BioSimulators schema. Documentation is available at https://api.biosimulators.org/.
- 
-   400 Client Error: Bad Request for url: https://api.biosimulators.org/simulators/validate

The test suite should display the source and detail attributes from the validator's response.

@jonrkarr jonrkarr added the enhancement New feature or request label Jan 29, 2021
@jonrkarr jonrkarr self-assigned this Jan 31, 2021
@jonrkarr
Copy link
Member Author

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

No branches or pull requests

1 participant