Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct relative model references in Villar SBML-core example #14

Closed
jonrkarr opened this issue Jan 11, 2021 · 1 comment
Closed

Correct relative model references in Villar SBML-core example #14

jonrkarr opened this issue Jan 11, 2021 · 1 comment
Assignees
@jonrkarr
Labels
bug Something isn't working

Comments

@jonrkarr
Copy link
Member

The mistake in the example originates from VCell's non-standard support for relative model references. Relative references should begin with a #.
@jonrkarr jonrkarr added the bug Something isn't working label Jan 11, 2021
@jonrkarr jonrkarr mentioned this issue Jan 11, 2021
Closed
@jonrkarr jonrkarr self-assigned this Feb 27, 2021
@jonrkarr
Copy link
Member Author

I decided to handle this differently:

  • Keep the curated examples simple
  • Remove model resolution via URL fragments from the curated examples
  • Test model resolution via URL fragments through synthetically generated COMBINE archives

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jonrkarr jonrkarr

Labels
bug Something isn't working
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

correcting relative model references to begin with a # biosimulators/Biosimulators_test_suite
1 participant
@jonrkarr