Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for other downloads and sources #2

Open
biomadeira opened this issue Jun 25, 2017 · 2 comments
Open

Adding support for other downloads and sources #2

biomadeira opened this issue Jun 25, 2017 · 2 comments

Comments

@biomadeira
Copy link
Owner

Just of the top of my head...

PDB

UniProt

DSSP

Ensembl

CATH

@fsimkovic
Copy link
Contributor

fsimkovic commented Jun 25, 2017

Have you considered a more modular structure?

A fetcher sub-package with modules/objects for each file type? This would allow different servers to be set as well, i.e. the RCSB PDB offers PDB file assemblies amongst other options. This would also make such expansion a lot easier?!

@biomadeira
Copy link
Owner Author

@fsimkovic That would be much better going forward!

I guess we could have generic fetcher class and then as many sub-classes as services/data sources we want, with proper abstraction and expandability.

I will start a new Project to help delineate what needs to be refactored... Feel free to jump in on this! Your ideas and changes are much appreciated!

@biomadeira biomadeira added this to TODO in Modular Design Jun 25, 2017
@biomadeira biomadeira moved this from TODO to Issues in Modular Design Jun 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

2 participants