-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Loss function drmsd component commented out #16
Comments
What line are you referring to here? |
Lines 53 and 56 of |
While on the topic of loss functions, am I right that you apply the mask to the tertiary structure and primary sequence when you preprocess the data rather than masking it in the loss function? This seems bad to me because you are changing the protein itself before it is presented to the neural network and removing potential interactions the model should be acknowledging in making its angle predictions. |
Hey @TrentBrick , |
Processing the masks in the preprocessing was purely done for efficiency reasons (faster that doing it in every training iteration). But of course if a given model needs the masked values, the preprocessing script should have an option not to apply the mask. |
I was wondering why you commented out the drmsd component of the loss function while training?
The text was updated successfully, but these errors were encountered: