Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show "waiting" symbol / disable controls during certain operations #381

Open
fedarko opened this issue Sep 15, 2020 · 1 comment
Open

Show "waiting" symbol / disable controls during certain operations #381

fedarko opened this issue Sep 15, 2020 · 1 comment

Comments

@fedarko
Copy link
Collaborator

fedarko commented Sep 15, 2020

Brought up by @antgonza in #375:

When changing layouts it would be good to change the cursor to a waiting/processing pointer and ignore all interactions as a user (me) can continue clicking and changing layouts until the browser brakes

I think it would make sense to have a minimum tree size where this starts being triggered -- for small trees these precautions (or at least the waiting symbol) won't be necessary, but once we get up to say > 100k tips it may be worth adding this stuff in.

It would probably be best to set up reusable functions to enable / disable stuff, similarly to how parts of #319 work. This problem also came up during MetagenomeScope's development; I wound up using smooth transitions between the enabling/disabling operations there, since they were happening so quickly for small datasets I was worried it was gonna be a photosensitivity problem.

@fedarko
Copy link
Collaborator Author

fedarko commented Oct 13, 2020

The idea of "disable controls" came up today, where e.g. it's possible to click on the canvas a bunch of times which (unknowingly) triggers a bunch of searches throughout the tree for the closest node. As part of this issue, it'd be good to (while searching is happening) disable the canvas events, or at least the clicking ones.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant