-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Normalizer.normalize()
is performing sequence position validation which cannot be skipped
#705
Labels
keep alive
exempt issue from staleness checks
Comments
This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
github-actions
bot
added
the
stale
Issue is stale and subject to automatic closing
label
Nov 28, 2023
Bump |
github-actions
bot
removed
the
stale
Issue is stale and subject to automatic closing
label
Nov 29, 2023
This issue is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
github-actions
bot
added
the
stale
Issue is stale and subject to automatic closing
label
Mar 2, 2024
This issue was closed because it has been stalled for 7 days with no activity. |
jsstevenson
added
keep alive
exempt issue from staleness checks
and removed
stale
Issue is stale and subject to automatic closing
closed-by-stale
labels
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The code here tests whether the sequence position actually exists, but there isn't any way to skip this test which requires fetching sequence data. Would it not make sense to skip it when the
validate
parameter is set toFalse
? Also, I see there's a TODO in there which I guess should also be addressed (but not sure how):The text was updated successfully, but these errors were encountered: