Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wxWidgets fails when cross-compiling; #1433

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

gmeeker
Copy link

@gmeeker gmeeker commented Dec 10, 2021

Description

Fix library file names to match package recipe when cross compiling.

Related Issue

closes #1432

Motivation and Context

Corrects library names when cross compiling. This is easy to reproduce on macOS (and probably iOS).
The current wxWidgets code in git has changed further, and I've included a 3.1.6 patch even though it hasn't been released. The original patch is definitely 3.1.5 only (3.1.4 and early don't name the libraries this way.)

How Has This Been Tested?

See steps in #1432
The test recipe is able to link now.
This change affects cross compiling Linux too, although I don't think that's possible to test until a Conan GTK recipe exists?
Windows (even if cross compiled) has different library names.

@Croydon
Copy link
Member

Croydon commented Dec 10, 2021

If 3.1.6 isn't yet released, can't the patch be still be included in the release? Nvm, I just read your issue. It is still unusual to add patches for versions we don't have yet. I would rather vote for not adding it for now

We have a GTK Conan package for 3.x and 4.x https://conan.io/center/gtk

Is wxWidgets compatible with it?

@gmeeker
Copy link
Author

gmeeker commented Dec 10, 2021

Yeah, I guess that was confusing. I've removed the 3.1.6 patch and I'll check back after it's released.

As for GTK, I didn't look into cross compiling Linux after finding issue #861 which I believe is where moving wxWidget to the Conan GTK package should be addressed? It seem to be still be open (some of the Linux builds here are failing). That issue seem to be out of date because the GTK package didn't seem to exist at the time. I can try to take a look separately. Can we ignore that here or would you like that to be fixed first to fully test cross compiling?

@gmeeker
Copy link
Author

gmeeker commented Dec 11, 2021

It looks like the wxWidgets recipe won't cross-compile on Linux anytime soon. There are other system dependencies besides GTK. This PR is effectively for macOS only.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

wxwidgets/3.1.5: build failure when cross compiling
2 participants