Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bincrafters-conventions: ability to skip bot #1285

Open
Croydon opened this issue Oct 9, 2020 · 3 comments
Open

bincrafters-conventions: ability to skip bot #1285

Croydon opened this issue Oct 9, 2020 · 3 comments
Assignees

Comments

@Croydon
Copy link
Member

Croydon commented Oct 9, 2020

sometimes it is just unwanted that the bot pushes convention updates, hence there should be a way to skip it

Possibilities:

  • add a tag to PR title
  • OR add a tag to PR description
  • OR add a tag to the latest(?)/any(?) commit message
  • OR detect if bots' commits got reverted (not sure how hard this is)
@Croydon Croydon self-assigned this Oct 9, 2020
@ericLemanissier
Copy link
Contributor

Also, maybe put a comment on the line you don't want the bot to modify ?

@Croydon
Copy link
Member Author

Croydon commented Oct 9, 2020

I don't like this idea as it would mean having to put tool specific meta data into recipes 🤔

@uilianries
Copy link
Member

Usually commit message is used for most CI services, but thinking about CCI, when I open a PR there and the bot updates, I would like something more straightforward, like the first option: add a tag to PR title.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants