Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

statsmodel: separate validation within modeling #862

Open
adelavega opened this issue May 23, 2022 · 0 comments
Open

statsmodel: separate validation within modeling #862

adelavega opened this issue May 23, 2022 · 0 comments
Labels
question statsmodels Pertain to implementation of BEP-002 - BIDS StatsModels

Comments

@adelavega
Copy link
Collaborator

in my recent PR, i ran into the issue that there was many spots where an invalid model would lead to an ugly crash.

i started adding logic to catch these errors, but realized that its mixing up implementation logic with validation logic.

i propose that we remove all validation logic from bids.modeling, and instead run the statsmodel validator and/or add a validation layer/plugin that separates this logic. i suppose the one issue that some of these errors require the design matrices to be built up in order to fully validate.

but at least in the case of @Shotgunosine's recent PR (checking for intercept only model) there are many issue that could be caught on the frontend and keep the main code cleaner.

@adelavega adelavega added question statsmodels Pertain to implementation of BEP-002 - BIDS StatsModels labels May 23, 2022
@adelavega adelavega changed the title statsmodel: validation within pyBIDS statsmodel: separate validation within pyBIDS May 23, 2022
@adelavega adelavega changed the title statsmodel: separate validation within pyBIDS statsmodel: separate validation within modeling May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question statsmodels Pertain to implementation of BEP-002 - BIDS StatsModels
Projects
None yet
Development

No branches or pull requests

1 participant