-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename "Variation" to "Variant" #70
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I propose that
GameLoader
and the other relevant classes are changed to read PGN tag "Variant" instead of the current "Variation". Wikipedia has this to say about the subject:As a practical example from the wild, Lichess exports the games with the "Variant" tag.
My hope would be that eventually the game loading system could be modified to ignore the variants that the library does not support, because when you export your games from Lichess, you get all the variant games as well, and the library crashes when it needs to parse certain, say, Crazyhouse moves.
If you don't see the complete renaming as a feasible plan, then a hacky way to fix the issue would be to treat the Variant tag as a synonym to the Variation tag. A third way would be to add "Variant" as a new attribute next to "Variation", keeping both. I would be willing to work on this issue and to create a pull request, once we just figure out the best way to approach it. My vote would go renaming Variation to Variant completely, though.
The text was updated successfully, but these errors were encountered: