Use esprima-fb from NPM by default. #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -25,7 +25,7 @@ | |||
| "debug": "node ./node_modules/mocha/bin/mocha --debug-brk --reporter spec" | |||
| }, | |||
| "dependencies": { | |||
| "esprima": "git+https://github.com/ariya/esprima.git#harmony", | |||
| "esprima-fb": "~5001.1.0-dev-harmony-fb", | |||
There was a problem hiding this comment.
Any particular reason to use ~ over ^ here? I know that ^ will accept different minor versions, but I forget if ~ does as well for versions greater than 1.0.0.
There was a problem hiding this comment.
Only because ^ isn't understood by older versions of npm (including the one that comes with node v0.8, I believe).
There was a problem hiding this comment.
who cares about node v0.8 anyways? jajaja, if you're using recast, you're probably living at that edge already :)
benjamn
added a commit
that referenced
this pull request
Aug 15, 2014
Use esprima-fb from NPM by default.
|
Published v0.7.0 to NPM: https://www.npmjs.org/package/recast Also did a GitHub release, for the first time ever (better now than never?): https://github.com/benjamn/recast/releases/tag/v0.7.0 |
|
awesome! thanks @benjamn |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that you can still use whatever parser you want by calling
recast.parsewithoptions.esprimaequal to any object with a compatible.parsemethod:recast.parse(source, { esprima: require("your-esprima") }).I will merge this as soon as @zpao or @jeffmo publishes the latest version of
esprima-fbto NPM.Closes #105.