-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support quoted identifiers #114
Comments
I think you looked into this deeper than I did and I agree with you! |
I was looking for an opinion on weather supporting the feature is worth breaking backward compatibility. Considering that BQL queries stored in Beancount input files are extremely likely to be using |
I forget if I added escapes in the Beancount syntax. That's going to be crucial for this change. |
Yes, the parser supports escaping double quotes as |
Currently BQL uses single
'
and double"
quotes interchangeably as string delimiters and does not have the concept of quoted identifiers. This make is impossible to have column names that collide with BQL keywords or that contain non-alphanumeric characters. This is sometimes annoying.Standard SQL uses single quotes
'
for string literals and double quotes"
for quoting identifiers. https://www.postgresql.org/docs/current/sql-syntax-lexical.html#SQL-SYNTAX-IDENTIFIERSShould BQL do the same? It would be a tiny patch to the parser. However, I expect this to break a fair number of user queries.
@blais, do you have an opinion?
The text was updated successfully, but these errors were encountered: