Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proper release of json-schema-ref-parser #469

Closed
lzgrzebski opened this issue Jul 25, 2022 · 5 comments
Closed

Proper release of json-schema-ref-parser #469

lzgrzebski opened this issue Jul 25, 2022 · 5 comments

Comments

@lzgrzebski
Copy link

lzgrzebski commented Jul 25, 2022

@apidevtools/json-schema-ref-parser@https://github.com/bcherny/json-schema-ref-parser.git#commit=984282d34a2993e5243aa35100fe32a63699164d: The remote archive doesn't match the expected checksum

Should we fork and release the version with proper version + tag instead of pointing to arbitrary refs?

@Kiran554
Copy link

Kiran554 commented Jul 28, 2022

This is not ideal. As it creates reference to github which might not be reachable for internal repositories. Please release another version to fix this.

@bradenneufeld
Copy link

bradenneufeld commented Aug 3, 2022

+1, This is breaking our CodeBuild pipeline.

[Container] 2022/08/03 05:01:18 Running command npm ci
npm ERR! Error while executing:
npm ERR! /usr/bin/git ls-remote -h -t ssh:https://[email protected]/bcherny/json-schema-ref-parser.git
npm ERR! 
npm ERR! Please make sure you have the correct access rights
npm ERR! and the repository exists.
npm ERR! 
npm ERR! exited with error code: 128

@Quentigus
Copy link

Quentigus commented Aug 5, 2022

+1, I can't use recent releases because of this reference :(

npm ERR! Error while executing:
npm ERR! git ls-remote -h -t https://github.com/bcherny/json-schema-ref-parser.git
npm ERR!
npm ERR! fatal: unable to access 'https://github.com/bcherny/json-schema-ref-parser.git/': Failed to connect to github.com port 443: Timed out
npm ERR!
npm ERR! exited with error code: 128

@bradenneufeld
Copy link

After reviewing npm/cli#2610, I was able to resolve in our CI/CD pipeline (AWS Codebuild) by updating our projects to use the new aws/codebuild/standard:6.0 image (node 16/npm 8) instead of aws/codebuild/standard:5.0 (node 14/npm 6).

@bcherny bcherny closed this as completed in 84c9db1 Aug 6, 2022
@bcherny
Copy link
Owner

bcherny commented Aug 6, 2022

Forking json-schema-ref-parser for now. Will switch back to the upstream once APIDevTools/json-schema-ref-parser#272 is merged.

Published in 11.0.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants