Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use fs from node instead of normalize/mz #270

Closed
beckerei opened this issue Nov 13, 2019 · 2 comments
Closed

Use fs from node instead of normalize/mz #270

beckerei opened this issue Nov 13, 2019 · 2 comments
Assignees
Labels

Comments

@beckerei
Copy link

beckerei commented Nov 13, 2019

Is it still needed to support older node version that don't support readFile, writeFile?

mz ships with a dependancy to any-promise.

Are you willing to accept a PR to use nodes own implementation

@bcherny
Copy link
Owner

bcherny commented Nov 30, 2019

Hey there @beckerei! We use mz for the Promises. Since native Promise-based APIs were introduced pretty recently in Node 10, I'd like to stick with mz for now to support whatever Node version people might be using. Is there a particular issue you're running into due to the dependency on mz?

@bcherny bcherny self-assigned this Nov 30, 2019
@bcherny bcherny closed this as completed Nov 30, 2019
@beckerei
Copy link
Author

beckerei commented Dec 1, 2019

Prior I thought it we had conflicts our test env, but then noticed the lib was not called during tests. So this was not an issue. Maybe others might have this problem at some point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants