Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify using custom slice sources #78

Closed
forman opened this issue Mar 9, 2024 · 0 comments · Fixed by #80
Closed

Simplify using custom slice sources #78

forman opened this issue Mar 9, 2024 · 0 comments · Fixed by #80
Assignees
Labels
enhancement New feature or request

Comments

@forman
Copy link
Member

forman commented Mar 9, 2024

Is your feature request related to a problem? Please describe.

Using custom slice sources can be simplified by not forcing slice sources to return a SliceSource instance.
Instead, slice source functions should be allowed to return a SliceObj.

Describe the solution you'd like

As described above.

  • Rewrite tests, add new, implement changes
  • Rename argument slice_obj into slice_item to underline it is one of the elements of the slices iterator passed to zappend
  • Update (simplify) user guide, especially confusing section about slice sources and slice factories
@forman forman added the enhancement New feature or request label Mar 9, 2024
@forman forman self-assigned this Mar 9, 2024
@forman forman changed the title Simplify using custom slice source Simplify using custom slice sources Mar 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant