Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Opened file underlying a persistent slice dataset closed too early #31

Closed
forman opened this issue Jan 22, 2024 · 0 comments · Fixed by #32
Closed

Opened file underlying a persistent slice dataset closed too early #31

forman opened this issue Jan 22, 2024 · 0 comments · Fixed by #32
Assignees
@forman
Labels
bug Something isn't working

Comments

@forman
Copy link
Member

forman commented Jan 22, 2024

The opened file underlying a persistent slice dataset is closed immediately after opening:

zappend/zappend/slice/persistent.py

Lines 77 to 78 in 15a95cc

with self._slice_file.fs.open(self._slice_file.path, "rb") as f:
return xr.open_dataset(f, engine=engine)

@forman forman added the bug Something isn't working label Jan 22, 2024
@forman forman self-assigned this Jan 22, 2024
@forman forman mentioned this issue Jan 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@forman forman

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed a problem with underlying i/o stream of a persistent slice bcdev/zappend
1 participant
@forman