Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for processing disposable slice sources #13

Closed
forman opened this issue Jan 12, 2024 · 0 comments · Fixed by #16
Closed

Allow for processing disposable slice sources #13

forman opened this issue Jan 12, 2024 · 0 comments · Fixed by #16
Assignees
Labels
enhancement New feature or request

Comments

@forman
Copy link
Member

forman commented Jan 12, 2024

In addition to passing xr.Dataset instances to the zappend processor, it would be very useful to allow for passing objects that yield a slice xr.Dataset when requested. After the slice has been processed the object would be closed, giving it the chance to dispose or cleanup temporary resources.

In fact, allow for passing instances of the zappend.slicesource.SliceSource ABC as input to the processor. Users could then provide their own slice source by implementing its abstract open and close methods.

@forman forman self-assigned this Jan 12, 2024
@forman forman added the enhancement New feature or request label Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant