Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to Show difference In EditedText and Old Text which was previously supported by bbc react editor? #234

Open
krmadala opened this issue May 15, 2020 · 1 comment
Labels
bug Something isn't working

Comments

@krmadala
Copy link

Previously bbc react Editor Showing Color difference in Edited Text But now That Feature is not available with new Enhancements.Is There is any reason for removing that feature?.In 2018 we took bbc react editor project and done some customization based on our requirements.Know we Identified issues with Copy paste .To Resolve that i was updated editor changes in my Project with bbc react Editor Current Changes but I lost the feature showing color differnce of Edited Text.Can Some help me about this or give me some information.

@krmadala krmadala added the bug Something isn't working label May 15, 2020
@krmadala krmadala changed the title How to Show difference In EditedText and Old Text which was previously supported by bbc reeact editor? How to Show difference In EditedText and Old Text which was previously supported by bbc react editor? May 15, 2020
@pietrop
Copy link
Contributor

pietrop commented May 15, 2020

Hi @krmadala,
It was removed because it was half baked,

  • It didn't handle all the use cases for a good UX. eg if you manually correct a word, it would still have the blue underline. For a good UX, If you correct a word with low confidence score it should remove the underline (to mark it as "done").
  • when they were not provided it would mark everything as low confidence Refactor #53 (comment)
  • Confidence scores are generally pretty unreliable.
  • Confidence scores are inconsistent across STT providers.
  • There was no evidence that users would actually benefit from having confidence score indications in the transcript when correcting it, or that it would make it easier or faster to correct the text.

If you want to bring it back, you can probably discuss a PR with @jamesdools and @emettely

I've been more active working on an alternative version built on top of slateJs slate-transcript-editor - demo to address #150

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants