Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Progress bar bug on large screen #202

Open
pietrop opened this issue Oct 4, 2019 · 3 comments
Open

Progress bar bug on large screen #202

pietrop opened this issue Oct 4, 2019 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@pietrop
Copy link
Contributor

pietrop commented Oct 4, 2019

Describe the bug

The progress bar looks off on large screens (27-inch) - see screenshot

To Reproduce
Steps to reproduce the behavior:

Load demo storybook app on a large screen, eg 27-inch

Expected behavior

For the progress bar to look the same on a larger screen.

Screenshots

bug-progress-bar

Additional context

NA

@pietrop pietrop added the bug Something isn't working label Oct 4, 2019
@jamesdools jamesdools self-assigned this Oct 7, 2019
@pietrop
Copy link
Contributor Author

pietrop commented Oct 7, 2019

is this what is causing the issue /packages/components/media-player/src/ProgressBar.module.scss#L3?

$slider-width-number: 1440;

is 1440 supposed to be a max screen width?

@emettely
Copy link
Contributor

emettely commented Oct 7, 2019

Also, weirdly maybe unrelated - I'm seeing a gap in progress bar when progressing further into the video.
Screen Shot 2019-10-07 at 13 37 32

@pietrop
Copy link
Contributor Author

pietrop commented Oct 7, 2019

Interesting, I wasn't able to reproduce that @emettely

I did noticed tho that if I change slider-width-number to be 2290 then the problem is fixed (?) at least on a 27in screen.

$slider-width-number: 2290;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants