Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: bazelbuild/rules_go
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.44.1
Choose a base ref
...
head repository: bazelbuild/rules_go
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.44.2
Choose a head ref
  • 4 commits
  • 14 files changed
  • 4 contributors

Commits on Dec 30, 2023

  1. Make C++ toolchain optional (#3390)

    * Make C++ toolchain optional
    
    Currently, if you transition a go_binary, you must have a C++ toolchain
    for it even if it's building in pure mode without cgo.
    
    By making this toolchain optional, we push the error from a
    toolchain-resolution-time error to an analysis-time error only if a
    toolchain is both _needed_ and not found.
    
    * Add tests
    
    * Add target that actually uses cgo
    
    * Switch to use bazel_features
    
    Also switch from @bazel_tools//tools/cpp:current_cc_toolchain to
    @bazel_tools//tools/cpp:optional_current_cc_toolchain because otherwise
    we still get a hard error if the toolchain can't be found.
    
    * Review comments
    illicitonion authored Dec 30, 2023
    Configuration menu
    Copy the full SHA
    b5d0db5 View commit details
    Browse the repository at this point in the history

Commits on Jan 2, 2024

  1. Fix a race detected only if a test times out (#3808)

    * Fix a race detected only if a test times out
    
    I believe this can happen because the goroutine is started before the
    command is started. Start the process first, then on success, start the
    signal handler. Add a test for regression.
    
    I verified the test fails without my change to wrap.go and the race is
    from the signal handling goroutine.
    
    * Register signal handler before cmd.Start()
    patrickmscott authored Jan 2, 2024
    Configuration menu
    Copy the full SHA
    5540b97 View commit details
    Browse the repository at this point in the history

Commits on Jan 3, 2024

  1. Configuration menu
    Copy the full SHA
    5b9d2c0 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    cea5f9f View commit details
    Browse the repository at this point in the history
Loading