Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blaze Icon Leaks Through For Non-Incremental Sync (With Fix) #2762

Open
cpsauer opened this issue Jul 8, 2021 · 2 comments
Open

Blaze Icon Leaks Through For Non-Incremental Sync (With Fix) #2762

cpsauer opened this issue Jul 8, 2021 · 2 comments
Labels
not stale Issues or PRs that are inactive but not considered stale P4 This is either out of scope or we don't have bandwidth to review a PR. (No assignee) product: IntelliJ IntelliJ plugin topic: sync Issues related to the sync operation type: bug

Comments

@cpsauer
Copy link
Contributor

cpsauer commented Jul 8, 2021

Hello wonderful Bazel folks,

I'd noticed the slow variant of the Blaze logo was leaking through into the Bazel plugin menu for non-incremental sync, like so:

Screen Shot 2021-07-08 at 12 15 04 AM

I figured that was probably an oversight, and that you'd wanted all Bazel logos in the external version, so I figured I'd give a heads up.

For quick reference, I've replaced it with the normal bazel logo it in the fork I've made to get the plugin working externally. hedronvision@43ecaae. You're welcome to just apply that patch, but a better fix might add a "slow" version of the Bazel logo and delete the unused assets. Was hesitant to do that because I'm not sure what you're doing with the Blaze logos internally.

Thanks for the work you do!
Chris
(ex-Googler)

@sgowroji sgowroji added type: bug product: IntelliJ IntelliJ plugin topic: sync Issues related to the sync operation awaiting-maintainer Awaiting review from Bazel team on issues labels Nov 2, 2022
@mai93 mai93 added the P2 We'll consider working on this in future. (Assignee optional) label Nov 2, 2022
@mai93 mai93 added the P4 This is either out of scope or we don't have bandwidth to review a PR. (No assignee) label Nov 15, 2022
@mai93 mai93 removed their assignment Nov 15, 2022
@mai93 mai93 removed P2 We'll consider working on this in future. (Assignee optional) awaiting-maintainer Awaiting review from Bazel team on issues labels Nov 15, 2022
@github-actions
Copy link

Thank you for contributing to the IntelliJ repository! This issue has been marked as stale since it has not had any activity in the last 6 months. It will be closed in the next 14 days unless any other activity occurs or one of the following labels is added: "not stale", "awaiting-maintainer". Please reach out to the triage team (@bazelbuild/triage) if you think this issue is still relevant or you are interested in getting the issue resolved.

@github-actions github-actions bot added the stale Issues or PRs that are stale (no activity for 30 days) label May 18, 2023
@cpsauer
Copy link
Contributor Author

cpsauer commented May 18, 2023

@bazelbuild/triage, this issue still relevant AFAIK! Worth fixing for Android Studio, too.

(@bazelbuild/triage didn't seem to create a tag last I tried (no link) so I'm going to also tag @sgowroji and @Pavank1992 manually. Please coach me if you'd have preferred otherwise--and maybe update the bot's instructions)

@sgowroji sgowroji added not stale Issues or PRs that are inactive but not considered stale and removed stale Issues or PRs that are stale (no activity for 30 days) labels May 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
not stale Issues or PRs that are inactive but not considered stale P4 This is either out of scope or we don't have bandwidth to review a PR. (No assignee) product: IntelliJ IntelliJ plugin topic: sync Issues related to the sync operation type: bug
Projects
Status: Backlog
Development

No branches or pull requests

3 participants