Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remote execution/caching: don't create gRPC messages that are too large #6373

Closed
ola-rozenfeld opened this issue Oct 12, 2018 · 0 comments
Closed
Assignees
Labels
P2 We'll consider working on this in future. (Assignee optional) type: bug

Comments

@ola-rozenfeld
Copy link
Contributor

Currently, if an action has lots of inputs, we can run into a situation where a GetMissingBlobs request ends up being over the default 4MB gRPC message size limit.

This also relates to the ongoing work on batching upload requests, and how our channel message size will have to be affected by the remote server capabilities.

Ultimately, we should split messages up to fit under the limit, even if we do end up with configuring that limit to a higher value.

@ola-rozenfeld ola-rozenfeld self-assigned this Oct 12, 2018
@bergsieker bergsieker added this to the Remote Execution milestone Oct 14, 2018
@philwo philwo added type: bug P2 We'll consider working on this in future. (Assignee optional) category: remote execution / caching labels Oct 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 We'll consider working on this in future. (Assignee optional) type: bug
Projects
None yet
Development

No branches or pull requests

3 participants