Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openSUSE package #59

Open
jubalh opened this issue Oct 4, 2022 · 2 comments
Open

openSUSE package #59

jubalh opened this issue Oct 4, 2022 · 2 comments

Comments

@jubalh
Copy link

jubalh commented Oct 4, 2022

I'm a package maintainer for openSUSE and wanted to package GetIt.

It seems that so far you depend on having git installed so that you can pull down some third party stuff.
In many distribution build systems this won't possible as distributions want to pull everything in advance and put it into a tar file, having reproducible and pristine tarballs.

It would be great if you could have this dependency tracked as a regular dependency in CMake (like boost etc) or could include it in your repository or your release tarball.

Build output:

[   29s] -- The C compiler identification is GNU 12.2.1
[   29s] -- The CXX compiler identification is GNU 12.2.1
[   29s] -- Detecting C compiler ABI info
[   29s] -- Detecting C compiler ABI info - done
[   30s] -- Check for working C compiler: /usr/bin/cc - skipped
[   30s] -- Detecting C compile features
[   30s] -- Detecting C compile features - done
[   30s] -- Detecting CXX compiler ABI info
[   30s] -- Detecting CXX compiler ABI info - done
[   30s] -- Check for working CXX compiler: /usr/bin/c++ - skipped
[   30s] -- Detecting CXX compile features
[   30s] -- Detecting CXX compile features - done
[   30s] -- Found Boost: /usr/lib64/cmake/Boost-1.80.0/BoostConfig.cmake (found version "1.80.0") found components: system 
[   30s] -- Found OpenSSL: /usr/lib64/libcrypto.so (found version "1.1.1q")  
[   30s] CMake Error at /usr/share/cmake/Modules/ExternalProject.cmake:2789 (message):
[   30s]   error: could not find git for clone of extern_restsdk-populate
[   30s] Call Stack (most recent call first):
[   30s]   /usr/share/cmake/Modules/ExternalProject.cmake:4170 (_ep_add_download_command)
[   30s]   CMakeLists.txt:23 (ExternalProject_Add)
[   30s] 
@bartkessels
Copy link
Owner

Hi,

Thanks for the feedback, in the feature/windows-package branch there's a CMake argument you can pass to use the system installed dependencies instead of fetching them using git.

So if you generate the Makefiles using -Duse_installed_dependencies=true then the dependencies won't be fetched pre-compile time. However, I'm not entirely sure whether this works perfectly since I'm having the same issues you have trying to build a Flatpak so there might be another solution in the end.

So I'll keep you updated through this issue, and if you find a way to properly solve the problem while being able to just clone the source and not have to worry about installing dependencies let me know!

@jubalh
Copy link
Author

jubalh commented Oct 14, 2022

Thanks for the feedback, in the feature/windows-package branch there's a CMake argument you can pass to use the system installed dependencies instead of fetching them using git.

That branch has quite a lot of commits. I guess I'll wait for the next release and check then again :)

I would suggest to use system dependencies by default, since this is what the big majority of applications do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants