New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: `table.addColumn` and `table.addColumns` have incorrect type signatures. #462

Open

DanKaplanSES opened this issue Jan 31, 2024 · 0 comments

Labels

Contributor

DanKaplanSES commented Jan 31, 2024

console-table-printer/src/console-table-printer.ts

Lines 16 to 24 in c51f8d9

 addColumn(column: string) { 

 this.table.addColumn(column); 

 return this; 

 } 

 addColumns(columns: string[]) { 

 this.table.addColumns(columns); 

 return this; 

 }

These type signatures say these methods only accept strings but that is not the case and it contradicts the documentation:

addColumn(columnObject) adding single column
addColumns(columnObjects) adding multiple columns

DanKaplanSES mentioned this issue

feat: The Computed Column function is passed row, index, and array #464

Draft

ayonious added the bug label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment