Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tables doesn't displaying in Heroku #383

Open
IvanGodinez21 opened this issue Jul 10, 2021 · 6 comments
Open

Tables doesn't displaying in Heroku #383

IvanGodinez21 opened this issue Jul 10, 2021 · 6 comments
Labels
bug Something isn't working

Comments

@IvanGodinez21
Copy link

When I try to use it in Heroku (A PaaS that works using Ubuntu), tables doesn't display as should be

image

@ayonious ayonious added the bug Something isn't working label Aug 5, 2021
@ayonious
Copy link
Owner

ayonious commented Aug 5, 2021

Yes I have noticed this before while running the tests on Heroku/circle-ci/travis. They use a different Terminal that what we use in local.

The solution is I need to find a way to detect terminal type and use proper ascii color code for that terminal.

@ArjixWasTaken
Copy link

A lazy and easy fix would be to rely on an environment variable to choose what ascii color codes to use.

@ayonious
Copy link
Owner

ayonious commented Aug 5, 2021

@ArjixWasTaken sounds good

@ayonious
Copy link
Owner

@IvanGodinez21 is this not happening anymore?

@IvanGodinez21
Copy link
Author

Oh, @ayonious I didn't see any update related to this issue, so I decided to close it, but if you want to re-open it, you can do it. Maybe this issue could be hard to fix, and not just in Heroku, there are many other platforms that may have this bug.

I leave it to your decision

@ayonious ayonious reopened this Dec 16, 2021
@ayonious
Copy link
Owner

With this following feature no more special char would be printed which is lot better than having broken CI views.
https://console-table.netlify.app/docs/doc-no-ascii

I wont consider this completely fixed but at least the basic table view should be seen using this. Styling can be done later

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants