Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong check of onnx environment #34

Closed
alex-aparin opened this issue Jun 14, 2023 · 1 comment
Closed

Wrong check of onnx environment #34

alex-aparin opened this issue Jun 14, 2023 · 1 comment

Comments

@alex-aparin
Copy link

alex-aparin commented Jun 14, 2023 •
edited
Loading

!_onnxEnvironment expression should be evaluated before usage of _onnxEnvironment->DeviceId in the code void StableDiffusionModelExecutor::EnsureEnvironment(std::string_view modelId) { if (_modelId != modelId || _onnxEnvironment->DeviceId != int32_t(_unpaintOptions->AdapterIndex()) || !_onnxEnvironment)
@axodox
Copy link
Owner

axodox commented Jun 14, 2023

Yes, I guess I have not realized it since when _onnxEnvironment is nullptr, modelId were also not equal, so the mistake was not realized as an error. I pushed a fix.

@axodox axodox closed this as completed Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alex-aparin @axodox