Generate NuGet symbol and source packages #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RomainMuller
approved these changes
Sep 25, 2018
There was a problem hiding this comment.
Looks good to me... Would like to get @costleya to have a quick look as well, though.
eladb
approved these changes
Sep 25, 2018
|
I'm mostly ok with this, but I need to do some small changes to the publishing script to support pushing the symbols to https://nuget.smbsrc.net/. |
|
@costleya but am I safe to merge the PR now? Or should I wait until you've prepared the publishing script updates? |
|
@costleya ping |
|
I have a conflict-free version of this branch, and submitted a PR on our publishing script to hopefully correctly publish the symbol packages to the right location. |
|
@costleya what should we do with this? Can you pick this up please? |
srchase
added
feature-request
RomainMuller
added a commit
that referenced
this pull request
Feb 4, 2019
### Bug Fixes * remove use of private API ([#351](#351)) ([874cbac](874cbac)), closes [#350](#350) * **jsii-dotnet-runtime:** Fix EPIPE on Windows. ([1d7cc8b](1d7cc8b)), closes [#341](#341) * **jsii-dotnet-runtime:** Redirect to STDERR. ([e20f401](e20f401)) * **kernel:** Improve tagged type of wire values ([#346](#346)) ([8ea39ac](8ea39ac)), closes [#345](#345) ### Features * **jsii:** support multiple class declaration sites ([#348](#348)) ([4ecf28c](4ecf28c)) * Generate NuGet symbol and source packages ([#243](#243)) ([aafd405](aafd405))
Merged
RomainMuller
added a commit
that referenced
this pull request
Feb 4, 2019
### Bug Fixes * remove use of private API ([#351](#351)) ([874cbac](874cbac)), closes [#350](#350) * **jsii-dotnet-runtime:** Fix EPIPE on Windows. ([1d7cc8b](1d7cc8b)), closes [#341](#341) * **jsii-dotnet-runtime:** Redirect to STDERR. ([e20f401](e20f401)) * **kernel:** Improve tagged type of wire values ([#346](#346)) ([8ea39ac](8ea39ac)), closes [#345](#345) ### Features * **jsii:** support multiple class declaration sites ([#348](#348)) ([4ecf28c](4ecf28c)) * Generate NuGet symbol and source packages ([#243](#243)) ([aafd405](aafd405))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to Java source jars, these packages can be published to NuGet to aid debugging by consumers.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.