Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove curated package list from concepts page #8963

Merged
merged 1 commit into from
Nov 2, 2024

Conversation

sp1999
Copy link
Member

@sp1999 sp1999 commented Nov 2, 2024

Description of changes:
This PR removes the curated package list from concepts page as it is already being referenced on the same page above as a hyperlink to the updated list in the package management section. It makes sense to have a single source of truth for the updated list of curated packages. The PR also fixes the link for the EKS Distro documentation page.

Testing (if applicable):
make build

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@sp1999
Copy link
Member Author

sp1999 commented Nov 2, 2024

/cherry-pick release-0.21

@eks-distro-pr-bot
Copy link
Contributor

@sp1999: once the present PR merges, I will cherry-pick it on top of release-0.21 in a new PR and assign it to you.

In response to this:

/cherry-pick release-0.21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sp1999
Copy link
Member Author

sp1999 commented Nov 2, 2024

/cherry-pick release-0.20

@eks-distro-pr-bot
Copy link
Contributor

@sp1999: once the present PR merges, I will cherry-pick it on top of release-0.20 in a new PR and assign it to you.

In response to this:

/cherry-pick release-0.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@eks-distro-bot eks-distro-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 2, 2024
@sp1999
Copy link
Member Author

sp1999 commented Nov 2, 2024

/cherry-pick release-0.19

@eks-distro-pr-bot
Copy link
Contributor

@sp1999: once the present PR merges, I will cherry-pick it on top of release-0.19 in a new PR and assign it to you.

In response to this:

/cherry-pick release-0.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

codecov bot commented Nov 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.40%. Comparing base (fd108f5) to head (e244087).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8963      +/-   ##
==========================================
- Coverage   72.41%   72.40%   -0.01%     
==========================================
  Files         578      578              
  Lines       45386    45386              
==========================================
- Hits        32866    32863       -3     
- Misses      10790    10792       +2     
- Partials     1730     1731       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sp1999
Copy link
Member Author

sp1999 commented Nov 2, 2024

/approve

Copy link
Member

@abhay-krishna abhay-krishna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhay-krishna, sp1999

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eks-distro-bot eks-distro-bot merged commit 121b808 into aws:main Nov 2, 2024
8 checks passed
@eks-distro-pr-bot
Copy link
Contributor

@sp1999: new pull request created: #8964

In response to this:

/cherry-pick release-0.21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@eks-distro-pr-bot
Copy link
Contributor

@sp1999: new pull request created: #8965

In response to this:

/cherry-pick release-0.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@eks-distro-pr-bot
Copy link
Contributor

@sp1999: new pull request created: #8966

In response to this:

/cherry-pick release-0.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sp1999 sp1999 deleted the docs/remove-curated-package-list branch November 2, 2024 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/docs Documentation documentation lgtm size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants