Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve RPM building to handle "Version" and name the tarball #95

Open
nkadel opened this issue May 2, 2021 · 2 comments
Open

Improve RPM building to handle "Version" and name the tarball #95

nkadel opened this issue May 2, 2021 · 2 comments

Comments

@nkadel
Copy link

nkadel commented May 2, 2021

The RPM building setup has some issues.

  • The "Version" is not set in amazon-efs-utils.spec
    • The .spec file could be generated with an amazon-efs-utils.spec.in, and built with a VERSION in the Makefile
  • The generated tarball is named amazon-efs-utils.tar.gz, which does not hint at the version
    • The tarball can be generated with a VERSION in the Makefile
  • The "make rpm-only" option depends on "make tarball"
    • That could be a Makefile option
  • The "rmbuild" options don't have to have the source files copied into the "dist/rpmbuild" directory, they can use:
    • rpmbuild --define '_sourcedir $(PWD)'

With all that in place, it's be possible to build RPMs more completely and consistently.

@nkadel
Copy link
Author

nkadel commented May 3, 2021

See Pull Request 96.

@bahildebrand
Copy link

@nkadel thanks for the feedback. We'll have someone take a look at this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants