Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changelog for v1.44.142 is empty #4631

Closed
rittneje opened this issue Nov 20, 2022 · 3 comments
Closed

changelog for v1.44.142 is empty #4631

rittneje opened this issue Nov 20, 2022 · 3 comments
Assignees
Labels
documentation This is a problem with documentation. needs-review This issue or pull request needs review from a core team member. p3 This is a minor priority issue

Comments

@rittneje
Copy link
Contributor

Describe the issue

The changelog for v1.44.142 is completely empty, as are the GitHub release notes.

Links

https://github.com/aws/aws-sdk-go/blob/main/CHANGELOG.md
https://github.com/aws/aws-sdk-go/releases/tag/v1.44.142

@rittneje rittneje added documentation This is a problem with documentation. needs-triage This issue or PR still needs to be triaged. labels Nov 20, 2022
@RanVaknin RanVaknin added the p3 This is a minor priority issue label Mar 30, 2023
@isaiahvita isaiahvita self-assigned this Mar 30, 2023
@RanVaknin RanVaknin added needs-review This issue or pull request needs review from a core team member. and removed needs-triage This issue or PR still needs to be triaged. labels Mar 31, 2023
@isaiahvita isaiahvita assigned sbiscigl and unassigned isaiahvita Apr 4, 2023
@sbiscigl
Copy link
Contributor

sbiscigl commented Apr 4, 2023

created pull/4786 to address, our apologies, I actually meant to include the changelog message in the commit in that release.

Removes old model file for ssm sap and uses the new model file to regenerate client

which corresponds to the actual change log message from v1.44.141

service/ssm-sap: Updates service API, documentation, paginators, and examples

a aws service renamed their service from ssmsap to ssm-sap and the model files were not removed before the release causing a issue on our end. This does not result in side effects in the client, this simply corrects the naming of the model file. This will retroactively update the change log, will update the release messaging to reflect as well once merged.

@sbiscigl
Copy link
Contributor

sbiscigl commented Apr 4, 2023

updated release notes as well, let me know if you have any questions.

@sbiscigl sbiscigl closed this as completed Apr 4, 2023
@github-actions
Copy link

github-actions bot commented Apr 4, 2023

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation This is a problem with documentation. needs-review This issue or pull request needs review from a core team member. p3 This is a minor priority issue
Projects
None yet
Development

No branches or pull requests

4 participants