-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Question] sm-docker zips and uploads the current dir, not the target dir? #3
Comments
also if the current dir does not have a dockerfile, it will still spin off the codebuild job and fail during the build stage. Suggest checking for a dockerfile first before starting the process |
Hi @athewsey, yes this is expected. See
However, your point is valid, as the docker CLI honors the target directory and not the current directory. For e.g., |
@w601sxs - Good call, that's a great enhancement. |
From my investigations into #2, I saw that sm-docker is zipping and uploading the current folder, not the target folder, when a target is given. E.g:
sm-docker build ./docker # Uploads all of ./ (not just ./docker) to S3
Is this expected and deliberate for some reason? If you have lots of other stuff in your folder it can make for a significantly slower wait than the (also working)
cd ./docker && sm-docker build .
The text was updated successfully, but these errors were encountered: