Skipping the "is not a valid attribute" for custom attributes

[frranck]

Hello Walter, thanks for the lib.
Would there be a way to skip the "is not a valid attribute" for attributes name not in your list?
Cheers

[awalterschulze]

Could you explain your use case?

I think the attr check doesn't happen during parsing

graphAst, _ := gographviz.ParseString(`digraph G {}`)

So you could reuse the parsing library and then create your own more lenient graph

if err := gographviz.Analyse(graphAst, graph); err != nil {

[frranck]

I want to use your library to load some state machines, for this I need some extra node attributes like "initial state". Dot isn't complaining on unknown attributes so it's compatible with graphviz tools, but the Analyze function is throwing an error...

[frranck]

@awalterschulze Would that be possible to add a function like
func AddExtraAttr(k string) {
validAttrs[k] = Attr(k)
}
so I could patch the validAttrs map? or maybe setting validAttrs global ?

[awalterschulze]

I think this is where we first added the error check for attributes.

https://github.com/awalterschulze/gographviz/pull/25/files#diff-f88c16358abbd541327ed0fb84d3bc1b

[awalterschulze]

I don't like adding globals here.

We would need to inject it and make a new Analyse function that takes extra valid attrs or turns of valid attr checking.

Maybe this is something to experiment with on a fork, to see how much code it would be?

[fsaintjacques]

I would be interested in this, I'll take a stab at it.

[sinkingpoint]

@fsaintjacques did you get anywhere with this?

[fsaintjacques]

@sinkingpoint I ended up implementing my own gographviz.Interface since I needed other stuff.

[sinkingpoint]

Ah fair. I ended up doing the same, although it does seem like overkill

[akrentsel]

I'd quite like this as well. If nobody else grabs it, I may take a stab at it.

[sinkingpoint]

Mine is at https://github.com/sinkingpoint/kiora/blob/main/cmd/kiora/config/graph.go if you want something to work off of. I don't really have the bandwidth to support it