Fix isNumber to only accept numbers #14
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great :) Maybe you would like to add your test case as well? |
|
Hello? @drt24 |
|
I am working on something else at the moment, should come back to this in late October. |
|
Cool Thanks |
|
I would really love a test case that breaks the old code. |
|
Hello.
|
|
Cool. Thank you very much. That is really helpful.
Now we just need someone to include those in a test case to make sure we
don't regress. And then we can merge this.
…On Mon, 4 Sep 2017, 14:45 Kentaro Takakuwa, ***@***.***> wrote:
Hello.
".", "-.", "----." are the cases accepted as numbers by the old code.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#14 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABvsLeZa-YywnzA4ogFa7wMne70zpAydks5se_75gaJpZM4JLSCa>
.
|
|
No activity, so going to close. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13.
I am happy to give over my copyright on this change.