Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the "Name" property to "Model" under OllamaSharp.Models #37

Closed
mili-tan opened this issue Jun 4, 2024 · 5 comments
Closed

Change the "Name" property to "Model" under OllamaSharp.Models #37

mili-tan opened this issue Jun 4, 2024 · 5 comments

Comments

@mili-tan
Copy link
Contributor

mili-tan commented Jun 4, 2024

Hi, there
I just found some changes while checking https://github.com/ollama/ollama/blob/main/api/types.go and they are look like:

	// Name is deprecated, see Model
	Name string `json:"name"`

should we also make some changes to align with upstream?

(btw, I'm not a native English speaker, so sorry for my English if there are some mistakes or weirdness)

@awaescher
Copy link
Owner

Oh, nice find. Would you add this to the current pull request?

@mili-tan
Copy link
Contributor Author

mili-tan commented Jun 4, 2024

Is it better to change “Name” directly to “Model” or add “Model” and mark the original “Name” as obsolete, or just only change the JsonPropertyName?

@awaescher
Copy link
Owner

I would love to do mark Name as obsolete so that the devs don't face breaking changes for this

@mili-tan
Copy link
Contributor Author

mili-tan commented Jun 4, 2024

I added some changes, #38

@mili-tan mili-tan closed this as completed Jun 4, 2024
@awaescher
Copy link
Owner

Once again, thanks for contributing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants