-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change the "Name" property to "Model" under OllamaSharp.Models #37
Comments
Oh, nice find. Would you add this to the current pull request? |
Is it better to change “Name” directly to “Model” or add “Model” and mark the original “Name” as obsolete, or just only change the JsonPropertyName? |
I would love to do mark Name as obsolete so that the devs don't face breaking changes for this |
I added some changes, #38 |
Once again, thanks for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi, there
I just found some changes while checking https://github.com/ollama/ollama/blob/main/api/types.go and they are look like:
should we also make some changes to align with upstream?
(btw, I'm not a native English speaker, so sorry for my English if there are some mistakes or weirdness)
The text was updated successfully, but these errors were encountered: