Add keep_alive from 0.1.23, use Options #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and ChatRequest. Add Format to ChatRequest and GenerateCompletion. Make request Uris relative
|
Man, I must have totally overlooked this gem of a PR! Thanks a lot for your contribution, very welcome! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ollama 0.1.23 added the ability to define how long a model should stay loaded via the API. This means that this PR fixes #21.
Since options is a shared thing between the generate and chat enpoints (so not just for chat), I refactored it to be RequestOptions for GenerateCompletion and ChatRequest. This would fix #20.
The format parameter on ChatRequest and GenerateCompletion has also been implemented, addressing #19.
The Uris have been made relative, fixing #24.