Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Banner Issue #393

Open
yoyoypy opened this issue Oct 4, 2019 · 7 comments
Open

Banner Issue #393

yoyoypy opened this issue Oct 4, 2019 · 7 comments

Comments

@yoyoypy
Copy link

yoyoypy commented Oct 4, 2019

**Ideally we would expect you to raise a bug on AvoRed Official Website **
https://www.avored.com/discussion/category/general

Describe the bug
When showing banner, product list will dropped to bottom of page

To Reproduce
Steps to reproduce the behavior:

  1. Upload Banner
  2. Go to home page

Screenshots
Screenshot_19
Screenshot_20

Desktop (please complete the following information):

  • Version 3.0.1
@indpurvesh
Copy link
Member

@yoyoypy Sorry i don't really understand what is the bug?I don't really see the image

@yoyoypy
Copy link
Author

yoyoypy commented Oct 7, 2019

this view without banner

Screenshot_25

but when i add banner, there is massive gap/space between banner section and product card

Screenshot_26
Screenshot_27
Screenshot_28

btw where is css file for avored?
maybe i can modify little bit for this issue...

@indpurvesh
Copy link
Member

I have feeling that there is a JS compilation issue.
Take a look at this docs
https://laravel.com/docs/6.x/mix#custom-webpack-configuration

css Location: resources/less/app.less

run the below command to start compiling (webpack.mix.js ):

 npm install
 npm run watch

@yoyoypy
Copy link
Author

yoyoypy commented Oct 7, 2019

npm install npm run watch

this command didnt solve the problem, still get blank gap/space between banner and product list..

i think problem here, i will look it up
Screenshot_29

@yoyoypy
Copy link
Author

yoyoypy commented Oct 8, 2019

after removing height its become normal looks.
still searching where height come from

Screenshot_30

@marol1210
Copy link

@yoyoypy
have many banner items , each item dimension need equally

you can substitute your widget for basic widget

modules/avored/banner/resources/views/widget/index.blade.php

image

@indpurvesh
Copy link
Member

@yoyoypy i am using vue ant design component. Try reading thier docs it might help you.

https://www.antdv.com/

If not you can always override the blade.view file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants