-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
auto-detect elm version per file, instead of based on cwd #561
Comments
I think it would be the right thing to traverse directories upwards, and I'm under the impression that this is what Git and many other tools do too. But not 100% confident about all edge cases that may come up. I'd say, ask a few very experienced programmers if there are any problems with it, and if none of them come up with anything, just do it 😄 |
(Moved comments about --stdin to a separate issue, #563) |
Doing the version check separately for each file given on the command line would definitely be the right thing, since they may (in principle, at least) be from different Elm projects. And to make sure that |
Love this. I have done the same thing for my small Atom plugin that runs |
I haven't heard anyone bring this up in a long time, I'm guessing because very few folks have both 0.18 and 0.19 projects anymore? If anyone thinks this would still be useful, please chime in. |
In 0.8.1, the elm-version is auto-detected based on the presence of
elm.json
orelm-package.json
in the current working directory.Proposal: instead of checking the current working directory, for each file check the file's folder and if not found traverse upwards until a package file is found.
It seems like this would be more flexible, and still do the right thing in all current cases? I think this would also allow plugins to not have to pass
--elm-version
unless they are using--stdin
The text was updated successfully, but these errors were encountered: