-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Why is the focal length different in your rendering and img_choy2016? #64
Comments
Hi @BostonLobster , thanks for your question! Yes, that is correct, the focal length and the principal point is different. If you check our code (e.g. the arange_pixels function), you will see that we assume the image plane to be in [-1, 1] with the center being at 0. The format used by Choy et. al. is [0, H-1] x [0, W-1] with the center point at H/2, W/2. (As a side note: we use the Choy et al. renderings only as input for the encoder, so that we never need to use the camera intrinsics / extrinsics in our repo.) |
@m-niemeyer Thanks for your reply! I know the difference now. An additional question here: how to convert the format of Choy et. al. to yours where the image plane reside in [-1, 1]? I'm wondering if I use Choy et. al. rendering for both input and supervision, I have to modify the camera intrinsics. |
I would suggest to do either of the following:
where s = (2 / (H - 1)); if H and W are different, you need to two different values, but this is not the case for Choy et al. (as you have squared images). |
I'll try your suggestions! Many thanks!! |
I downloaded the ShapeNet for 2.5D supervised models dataset, and found there are two
cameras.npz
. One in obj_ID folder, another inimg_choy2016
folder.In the paper, you wrote "While we use the renderings from Choy et al. [13] as input, we additionally render 24 images of resolution 2562 with depth maps and object masks per object which we use for supervision." So, I guess one
cameras.npz
is for your rendering, the other for choy's.But the focal length in two
cameras.npz
are different:In yours, the focal is
but in choy's, the focal is
I think the focal length should be same, because you just changed the camera pose during additional rendering, right?
The text was updated successfully, but these errors were encountered: