-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should use less ! and do more inline error checking and form redisplay #885
Labels
Comments
Agree. Overall, the entire site needs more error handlers instead of simply crashing on the user. It's really frustrating when editing an assessment, one error causes all changes to be discarded. However, since there's many such problems, we'll need to focus on the more important and frequently occurring ones. But at least when writing new code, we should keep this in mind. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
There are many situations where autolab uses the ! form of an activerecord function, which will trigger donkey kong if a validation or other error occurs, instead of catching the validation error and redisplaying whatever form triggered it. Recent high-profile examples of this include all the error emails we've been getting about "You cannot submit because it is past the deadline" and some earlier errors when the the end time of an assessment was not updated when the start time changed.
The text was updated successfully, but these errors were encountered: