Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary lines from assets.rb #1670

Open
damianhxy opened this issue Dec 14, 2022 · 0 comments
Open

Remove unnecessary lines from assets.rb #1670

damianhxy opened this issue Dec 14, 2022 · 0 comments

Comments

@damianhxy
Copy link
Member

damianhxy commented Dec 14, 2022

Your environment
master (c5a0d53)

Current behavior
Currently, config/initializers/assets.rb has a list of paths to files that should be precompiled for production. However, it appears that most of them are redundant owing to the use of wildcards such as *.css and *.js

Besides, having to manually add a line for every new js or css file is error-prone.

Expected behavior
We should remove unnecessary precompile lines and verify that production autolab still functions.

Comments
I haven't been able to get production autolab running using the bare-metal Autolab installation.

We could possibly test this using autolab docker.

Alternatively, we could do the following

  • Run RAILS_ENV=development bundle exec rake assets:precompile
  • Check the list of precompiled files in public/assets
  • Removing unnecessary lines, purge the directory
  • Run the command again and compare the new list of files

Potential references:

@sync-by-unito sync-by-unito bot closed this as completed Jan 29, 2023
@michellexliu michellexliu reopened this Jan 29, 2023
@damianhxy damianhxy self-assigned this Jun 8, 2023
@damianhxy damianhxy removed their assignment Jun 16, 2023
@damianhxy damianhxy self-assigned this Jan 22, 2024
@damianhxy damianhxy mentioned this issue Feb 19, 2024
6 tasks
@damianhxy damianhxy removed their assignment Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants