Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrating Autolab Dark Theme #1260

Open
fanpu opened this issue Dec 4, 2020 · 0 comments
Open

Integrating Autolab Dark Theme #1260

fanpu opened this issue Dec 4, 2020 · 0 comments

Comments

@fanpu
Copy link
Contributor

fanpu commented Dec 4, 2020

There is an Autolab dark theme PR which allows each individual user to set whether they want the default Autolab theme, or the dark theme: #1139

This is a very promising PR but there are some issues with it which needs to be resolved before it can be merged.

  1. Certain aspects of the light theme (the handin-panel, the font colors and type, the handin table on submission page) were overwritten for convenience in the dark theme implementation. This should not be the case. There should not be UI changes for the current light theme.
  2. The naming conventions of the CSS variables, as well as how the CSS variables are managed can be improved. Hex codes representing the color are being used as the name of the color, but this is very uninformative and decreases readability.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants