Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling of invalid archive files should be improved #1129

Open
cg2v opened this issue Apr 14, 2020 · 0 comments
Open

Handling of invalid archive files should be improved #1129

cg2v opened this issue Apr 14, 2020 · 0 comments

Comments

@cg2v
Copy link
Member

cg2v commented Apr 14, 2020

If a student submits a file that is considered an archive, but the archive is invalid, then submissions#view throws an exception (and displays donkey kong)

In addition to catching and displaying an appropriate error for this exception, it may make sense for validateHandin to reject archives that trigger exceptions from Archive.get_file_hierarchy. (that's not perfect - a zip file could have a valid directory but still fail a later extract, but it's better than what we have now)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants