Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Current custom autoloader is very slow #783

Closed
szepeviktor opened this issue Apr 5, 2020 · 2 comments · Fixed by #787
Closed

Current custom autoloader is very slow #783

szepeviktor opened this issue Apr 5, 2020 · 2 comments · Fixed by #787

Comments

@szepeviktor
Copy link
Contributor

Description

The current autoloader is brute-forcing its way through PHP files.

Suggestion

As Composer autoloader is already included
@joshcanhelp please consider using it for loading all our classes with "classmap"

May I send a PR?
@joshcanhelp
Copy link
Contributor

As long as it's not a breaking change, that would be great!

@szepeviktor szepeviktor mentioned this issue Apr 6, 2020
Merged
@szepeviktor
Copy link
Contributor Author

@joshcanhelp Done in 16 lines.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Load ourselves with Composer autoloader szepeviktor/wp-auth0
2 participants
@joshcanhelp @szepeviktor