Custom settings are not saved due to newly introduced settings validation

[nturbanov]

Description

Custom settings fields (options) created using the auth0_settings_fields filter created as described in the documentation are not saved in the database upon saving changes in the Auth0 Settings.

I've tracked down the issue to the new validation done to settings where non-default option keys are unset.

// Remove unknown keys.
$option_keys = $this->a0_options->get_defaults( true );
foreach ( $input as $key => $val ) {
    if ( ! in_array( $key, $option_keys ) ) {
        unset( $input[ $key ] );
    }
}

There's currently no filter for the validation done here so the only way around this at the moment is to disable this validation.

Reproduction

Create a custom settings via the auth0_settings_fields filter as described here.

Go the Auth0 Settings in WP admin, input something in the custom field and Save Changes. Notice changes to the custom settings are not saved, instead the field is empty. Verify this by checking the value on the option wp_auth0_settings in the database.

To fix, comment out lines 99 to 104 in lib/admin/WP_Auth0_Admin.php.

Update setting again in WP admin and verify the custom setting is saved.

Environment

• v 4.0.0-beta

[joshcanhelp]

@nturbanov - Apologies for the trouble and I appreciate the detailed report here. We'll look into a fix right away.