Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Widget options accessable by the Plugin #15

Closed
mgonto opened this issue Sep 25, 2014 · 6 comments
Closed

Make Widget options accessable by the Plugin #15

mgonto opened this issue Sep 25, 2014 · 6 comments

Comments

@mgonto
Copy link
Contributor

mgonto commented Sep 25, 2014

We should let the user be able to set the widget options when calling in the signin configurable in the Settings page on the WP plugin

@glena
Copy link
Contributor

glena commented Sep 25, 2014

what do you mean with "widget option"?

@mgonto
Copy link
Contributor Author

mgonto commented Sep 29, 2014

This depends on #19 first.

Once that's done, you'll see that when you call the showSignin method it can receive lots of different options. Check how it's called now. The idea is that other than onestep and standalone which should be alwas there, the rest should be configurable through a JSon field. For a list of all options check here

@mgonto
Copy link
Contributor Author

mgonto commented Sep 29, 2014

Options to show in Settings:

  • dict: JSon object with the translations. Point to https://github.com/auth0/lock/wiki/Customizing-error-messages to show what can be configured. Also, it can be set to a particular language.
  • icon: Field to enter a URL to the icon
  • socialBigButtons: Checkbox to show Big buttons for Social Login or not
  • usernameStyle: Radio button to set to either username or email
  • gravatar: Checkbox to activate gravatar behaviour.
  • rememberLastLogin: Option to enable or not the last login
  • Extra Configurations: Text area to enter a JSon with Additional configurations

@glena
Copy link
Contributor

glena commented Sep 30, 2014

Questions:

  • dict: we are setting the widget title via the dict parameter (dict.signin.title). If the user sets also a dict json we can merbe both objects but what happens when the user sets a languaje (ie 'es')? Is there any way to send a languaje and a languaje? (seems that it can't be done https://github.com/auth0/lock/wiki/Auth0Lock-customization#dict-stringobject)
  • icon: There is already an option for the icon but it is a file input to upload an image, we can let the user do both upload or enter an URL

(note to self: still pending to implement extra configurations too)

@mgonto
Copy link
Contributor Author

mgonto commented Sep 30, 2014

icon: There is already an option for the icon but it is a file input to upload an image, we can let the user do both upload or enter an URL

I'd let the user do any of the 2.

dict: we are setting the widget title via the dict parameter (dict.signin.title). If the user sets also a dict json we can merbe both objects but what happens when the user sets a languaje (ie 'es')? Is there any way to send a languaje and a languaje? (seems that it can't be done https://github.com/auth0/lock/wiki/Auth0Lock-customization#dict-stringobject)

That case is not supported by Lock right now. Let's create an issue and for the time being, if he changes the language, we'll override what he puts as the Title.

@glena glena mentioned this issue Oct 4, 2014
@glena
Copy link
Contributor

glena commented Oct 8, 2014

merged!

@glena glena closed this as completed Oct 9, 2014
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants