Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev dependency listed as runtime dependency #58

Closed
dinofx opened this issue Sep 26, 2018 · 1 comment
Closed

dev dependency listed as runtime dependency #58

dinofx opened this issue Sep 26, 2018 · 1 comment

Comments

@dinofx
Copy link

dinofx commented Sep 26, 2018

The package.json contains:
"@types/express-jwt": "0.0.34",
as a runtime dependency. This should be moved to dev dependencies, since types are not needed at runtime.

The declaration file in express-jwt adds properties like user to the Express.Request interface, which conflicts with other libraries an app might be using (like passport), which try to declare the same property on Express.Request.

@damieng
Copy link
Contributor

damieng commented May 21, 2019

Fixed in #91

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants