-
Notifications
You must be signed in to change notification settings - Fork 233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
expressJwtSecret can return undefined which is not reflected in GetVerificationKey type #328
Labels
Comments
2 tasks
Hi @AaronMoat - thanks for raising this
It shouldn't be possibly to return any falsey value for |
Ah no, my bad - I see what you mean |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the problem
expressJwtSecret
in theGetVerificationKey
mode can return aPromise
ofundefined
, e.g. here:but
GetVerificationKey
returnsSecret | Promise<Secret>
to which undefined or Promise are not assignable.What was the expected behavior?
The typing for
GetVerificationKey
should includeundefined
.Reproduction
This fails to compile:
Environment
The text was updated successfully, but these errors were encountered: