Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Please document cacheMaxAge and jwksRequestsPerMinute #324

Closed
Aaronius opened this issue Sep 17, 2022 · 1 comment · Fixed by #327
Closed

Please document cacheMaxAge and jwksRequestsPerMinute #324

Aaronius opened this issue Sep 17, 2022 · 1 comment · Fixed by #327
Labels
documentation

Comments

@Aaronius
Copy link

Aaronius commented Sep 17, 2022 •
edited

Describe the problem you'd like to have solved

The cacheMaxAge and jwksRequestsPerMinute options could be better documented.

Describe the ideal solution

Please document cacheMaxAge and jwksRequestsPerMinute under JwksClient Options. For cacheMaxAge, please explicitly define what unit the value is in (milliseconds?).

Alternatives and current work-arounds

Additional information, if any
@Aaronius Aaronius changed the title Please document Please document cacheMaxAge and jwksRequestsPerMinute Sep 17, 2022
adamjmcgrath added a commit that referenced this issue Sep 20, 2022
@adamjmcgrath
Update index.d.ts
f63c4f9 
fixes #324
@adamjmcgrath adamjmcgrath mentioned this issue Oct 7, 2022
Merged
@adamjmcgrath
Copy link
Contributor

Thanks for raising this @Aaronius - raised #327

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update README.md auth0/node-jwks-rsa
2 participants
@Aaronius @adamjmcgrath